Merge review

The go-ahead to merge, what makes a pull request ready for it, and how Blume follows the merge on GitHub.

The merge review is the second step of the Review phase. The outcome is accepted, and the agent asks: merge this now? You answer once per pull request. The approval is bound to the pull request’s head commit and target branch, so a new push needs its own.

Connect GitHub first. Whether agents wait for this review is the workspace’s review policy. See Reviews.

The steps of Review

StepWaits forEnds when
Outcome reviewYouYou accept the result
Merge-readyThe agentEvery pull request is ready for its merge review
Merge reviewYouYou approve the merge
MergedGitHubEvery pull request is merged
The Review card on a delivery's Phases tab with two steps: Outcome review, waiting for you, on R1 with 3 of 6 acceptance checks passed and its Review outcome button, and Merge review, not yet, asked once every pull request is ready.The Review card on a delivery's Phases tab with two steps: Outcome review, waiting for you, on R1 with 3 of 6 acceptance checks passed and its Review outcome button, and Merge review, not yet, asked once every pull request is ready.
The Review card on the Phases tab of a delivery in Blume. Merge review waits until the outcome review is done and every pull request is ready.

Merge readiness

The agent asks only when the pull request is ready:

  • it is out of draft,
  • its head on GitHub is the delivery’s code,
  • its checks have finished and passed,
  • no review bot is still reviewing its head, and
  • nobody has requested changes on GitHub.

Until then, the Merge-ready step lists what is missing. A go-ahead you give counts whenever you give it.

Review a merge

  1. Open the delivery. The merge review is under Waiting on you on the Overview.
  2. Choose Review. Read the brief, then the tabs: PR description, PR checks and PR diff.
  3. Choose Approve merge (A), or Request changes (C) and send your note with ⌘ ↵.
  • Approving records your go-ahead. Blume does not merge. The agent merges, or you merge on GitHub.
  • Requesting changes makes a new revision. Your outcome approval carries to it once every acceptance check passes again.
  • Approving on GitHub counts: an approving review of the current head, by a person other than the author.
  • Approving in chat counts. The agent still runs the acceptance checks first.

After the merge

When every pull request is merged, the delivery moves to Release when it changes an application with release steps, or to Done when it ships nothing to users.